Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the function decorator and input / output type information #1141

Closed
1 of 2 tasks
xzdandy opened this issue Sep 17, 2023 · 1 comment
Closed
1 of 2 tasks

Redesign the function decorator and input / output type information #1141

xzdandy opened this issue Sep 17, 2023 · 1 comment
Labels
Duplicate 🔁 This issue or pull request already exists Feature Request ✨ New feature or request

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 17, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

  1. The information stored in function decorator should be accessed as class attributes, so we do not need to instantiate a function class to, e.g., get whether the function is cacheable or not.
  2. The type information in the current forward decorator is too tedious.
  3. Rename forward decorator, since not all functions are neural networks.

This feature request is closely related to #1017.

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added Feature Request ✨ New feature or request Duplicate 🔁 This issue or pull request already exists labels Sep 17, 2023
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 22, 2023

Duplicate of #1150 and #1017

@xzdandy xzdandy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate 🔁 This issue or pull request already exists Feature Request ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xzdandy