Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOAD CSV - the output returns the number of loaded frames. Improve messaging #1187

Closed
1 of 2 tasks
gaurav274 opened this issue Sep 21, 2023 · 1 comment · Fixed by #1228
Closed
1 of 2 tasks

LOAD CSV - the output returns the number of loaded frames. Improve messaging #1187

gaurav274 opened this issue Sep 21, 2023 · 1 comment · Fixed by #1228
Assignees
@gaurav274
Labels
Help Wanted 🙏 Outside help would be appreciated, good for new contributors User Experience
Milestone
v0.3.7

Comments

@gaurav274
Copy link
Member

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

In [8]: path = "data/ludwig/home_rentals.csv"

In [9]: load_query = f"LOAD CSV '{path}' INTO HomeRentals;"

In [10]: cur.query(load_query).df()
Out[10]: 
                            CSV  Number of loaded frames
0  data/ludwig/home_rentals.csv                     5037

Environment

  • EvaDB : 0.3.6

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@gaurav274 gaurav274 added this to the v0.3.7 milestone Sep 21, 2023
@xzdandy xzdandy moved this to No Status in EVA Public Roadmap ⚡🚀 Sep 22, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Sep 22, 2023

Shall we change number of loaded frames to number of loaded rows?

@xzdandy xzdandy moved this from No Status to ToDo in EVA Public Roadmap ⚡🚀 Sep 22, 2023
@xzdandy xzdandy added the Help Wanted 🙏 Outside help would be appreciated, good for new contributors label Sep 22, 2023
@gaurav274 gaurav274 self-assigned this Sep 27, 2023
@gaurav274 gaurav274 linked a pull request Sep 27, 2023 that will close this issue
fix: improve messaging and fix bugs #1228
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurav274 gaurav274

Labels
Help Wanted 🙏 Outside help would be appreciated, good for new contributors User Experience
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.7
Development

Successfully merging a pull request may close this issue.

fix: improve messaging and fix bugs georgia-tech-db/evadb
2 participants
@xzdandy @gaurav274