Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance similarity search test to make index is used #1199

Closed
1 of 2 tasks
jiashenC opened this issue Sep 23, 2023 · 0 comments · Fixed by #1212
Closed
1 of 2 tasks

Enhance similarity search test to make index is used #1199

jiashenC opened this issue Sep 23, 2023 · 0 comments · Fixed by #1212
Assignees
@jiashenC
Labels
Feature Request ✨ New feature or request Optimizations Features/Bugs related to optimizations
Milestone
v0.3.7

Comments

@jiashenC
Copy link
Member

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

Check if the query plan uses VectorIndexScan for pinecone, qdrant, chroma test cases. Example:

evadb/test/integration_tests/long/test_similarity.py

Line 256 in 0de4cd2

self.assertTrue("VectorIndexScan" in explain_batch.frames[0][0])

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@jiashenC jiashenC added the Feature Request ✨ New feature or request label Sep 23, 2023
@jiashenC jiashenC added this to the v0.3.7 milestone Sep 23, 2023
@xzdandy xzdandy added the Optimizations Features/Bugs related to optimizations label Sep 23, 2023
@jiashenC jiashenC self-assigned this Sep 25, 2023
@jiashenC jiashenC linked a pull request Sep 25, 2023 that will close this issue
fix: 1199 enhance similarity search test to make index is used #1212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiashenC jiashenC

Labels
Feature Request ✨ New feature or request Optimizations Features/Bugs related to optimizations
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.7
Development

Successfully merging a pull request may close this issue.

fix: 1199 enhance similarity search test to make index is used georgia-tech-db/evadb
2 participants
@xzdandy @jiashenC