Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-testmon to run the long integration tests that are affected by the open PR #1200

Closed
1 of 2 tasks
xzdandy opened this issue Sep 23, 2023 · 4 comments · Fixed by #1209
Closed
1 of 2 tasks
Assignees
Labels
Feature Request ✨ New feature or request
Milestone

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 23, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

For now, if open's pr adds or changes long integration test, they are not tested by circle ci before merging into staging branch. We can use pytest --testmon and circleci to cache the .testmondata, to only run the long integration tests are affected by the PR.

Hi @jiashenC, what do you think? Thanks!

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Feature Request ✨ New feature or request label Sep 23, 2023
@xzdandy xzdandy added this to the v0.3.7 milestone Sep 23, 2023
@jiashenC
Copy link
Member

Sure, this should be very useful.

@jiashenC
Copy link
Member

jiashenC commented Sep 24, 2023

@xzdandy I had a chance to test this, but it seems not working very well. Most tests need to be rerun even though I didn't change any source code. You can try running tests again using my PR.

@jiashenC jiashenC linked a pull request Sep 24, 2023 that will close this issue
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 24, 2023

@jiashenC Thanks for trying. I will give a try. I think testmon is using coverage, so we can not do no:cov.

@xzdandy xzdandy moved this to In Review in EVA Public Roadmap ⚡🚀 Sep 24, 2023
@xzdandy xzdandy moved this from In Review to In Progress in EVA Public Roadmap ⚡🚀 Sep 24, 2023
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 25, 2023

We need to use python -m pytest --testmon-forceselect test/integration_tests/long/ -m "not benchmark".

With --testmon, the -m option will overwrite the testmon's selection. I will update the #1209 accordingly.

Reference: https://testmon.org/#all-command-line-options

@xzdandy xzdandy self-assigned this Sep 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in EVA Public Roadmap ⚡🚀 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request ✨ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants