Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific error messages for function loading #1309

Closed
pchunduri6 opened this issue Oct 20, 2023 · 5 comments · Fixed by #1330
Closed

More specific error messages for function loading #1309

pchunduri6 opened this issue Oct 20, 2023 · 5 comments · Fixed by #1330
Assignees

Comments

@pchunduri6
Copy link
Contributor

The current message when a function cannot be loaded is:

err_msg = f"Couldn't load function from {filepath} : {str(e)}. This might be due to a missing Python package, or because the function implementation file does not exist, or it is not a valid Python file."

We should return specific error messages for each of the three cases.

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 20, 2023

Hi @pchunduri6, thanks for sharing the error message. Could you share what real error leads to this error message? Is that a typo in function name?

@pchunduri6
Copy link
Contributor Author

Hi @xzdandy, this error happened to me when the function was in the wrong location or when I had a bug in the function. Had a conversation with @jarulraj and we thought it's best to have a more precise error message for why the function fails instead of returning 3 possible reasons at once.

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 20, 2023

Thanks Pramod! Hi @hershd23 and @Omanshb, I think this issue is closely related to #1189 you are looking into. We may can fix them all together to improve the user experience.

@hershd23
Copy link
Contributor

Yes @xzdandy @pchunduri6. We are trying to solve for typos in functions and provide a close match to that. We can add these cases as well

@hershd23 hershd23 self-assigned this Nov 1, 2023
@hershd23
Copy link
Contributor

hershd23 commented Nov 1, 2023

Assigning this issue to myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants