Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector store not working properly with orderby clause #879

Closed
1 of 2 tasks
affan00733 opened this issue Jun 18, 2023 · 6 comments
Closed
1 of 2 tasks

vector store not working properly with orderby clause #879

affan00733 opened this issue Jun 18, 2023 · 6 comments
Assignees

Comments

@affan00733
Copy link
Member

Search before asking

  • I have searched the EVA DB issues and found no similar bug report.

EVA DB Component

Other

Bug

  • when performing the similarity based query on vector that is creating a vector store from the table features by FAISS and QDRANT, it seems to be corrupted as when locally reading the entire vector store of 2 pdfs it is returning 517
image

Environment

No response

Minimal Reproducible Example

import faiss index = faiss.read_index("/Users/afaanansari/Desktop/gtech/eva/tutorials/evadb_data/index/FAISS_faiss_indexs.index") index.ntotal

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@github-actions
Copy link
Contributor

👋 Hello @affan00733, thanks for your interest in EVA DB 🙏 Please visit our 🔮 Tutorials to get started, where you can find quickstart guides for simple tasks like Image Classification all the way to more interesting tasks like Emotion Analysis.

If this is a 🐞 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a ❓ Question, please provide as much information as possible, including dataset examples and query results.

@jiashenC
Copy link
Member

Can you provide detailed steps to reproduce this error? Not sure if this is related to order by desc, but #898 tests desc works fine.

@jiashenC
Copy link
Member

Error can be reproduced through tutorials/privategpt notebook.

  • Answers are not ordered correctly.
  • Limit clause not working.

@jiashenC jiashenC self-assigned this Jun 26, 2023
@jiashenC
Copy link
Member

The root cause is different paragraphs in from the same PDF are assigned to the same _row_id. Is this PR #868 intended to address this issue? @gaurav274

@gaurav274
Copy link
Member

Nice catch. Yes, we need to improve the support of creating indexes directly on unstructured tables.

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 22, 2023

I think the issue different paragraphs in from the same PDF are assigned to the same _row_id. this has been already addressed.

@xzdandy xzdandy closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants