Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file in the internal code and nondescriptive variable names #398

Open
chainsawriot opened this issue Apr 26, 2024 · 2 comments
Open

file in the internal code and nondescriptive variable names #398

chainsawriot opened this issue Apr 26, 2024 · 2 comments

Comments

@chainsawriot
Copy link
Collaborator

It is inconvenient to have a variable called file all over the code, especially in the case of using the debugger, where the symbol file is also a base function name.

I don't think we can change the API of import(file) and export(x, file) for now. But I would suggest adding filename <- file or something like that immediate when entering the functions and then working on filename.

@chainsawriot chainsawriot changed the title file in the interal code file in the interal code and nondescriptive variable names May 14, 2024
@chainsawriot
Copy link
Collaborator Author

Also,

type, file_type, compress, and sometimes ext are referring to a similar concept.

f, cfile, cfile2...

@chainsawriot
Copy link
Collaborator Author

f is also an unfortunate variable name, because in a debugger, it means "finish".

@chainsawriot chainsawriot changed the title file in the interal code and nondescriptive variable names file in the internal code and nondescriptive variable names May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant