Use a Convex function for Next.js auth checks #129
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -3,7 +3,7 @@ import GitHub from "@auth/core/providers/github"; | |||
| import { convexAuth } from "@convex-dev/auth/server"; | |||
| import { internal } from "./_generated/api"; | |||
|
|
|||
| export const { auth, signIn, signOut, store } = convexAuth({ | |||
| export const { auth, signIn, signOut, store, isAuthenticated } = convexAuth({ | |||
There was a problem hiding this comment.
I think one thing I don't like about this is that it expands the required members of the auth: namespace.
Maybe instead I can bundle it in the auth object that's already unpacked/exported here?
There was a problem hiding this comment.
That doesn't seem to work.
There was a problem hiding this comment.
Yeah I think this is kind of the only way to do this (we want a query, and need to add a new export for it)
If we made auth into a component, then we'd hide away some of the installation, but that's hard for other reasons
| @@ -3,7 +3,7 @@ import GitHub from "@auth/core/providers/github"; | |||
| import { convexAuth } from "@convex-dev/auth/server"; | |||
| import { internal } from "./_generated/api"; | |||
|
|
|||
| export const { auth, signIn, signOut, store } = convexAuth({ | |||
| export const { auth, signIn, signOut, store, isAuthenticated } = convexAuth({ | |||
There was a problem hiding this comment.
Yeah I think this is kind of the only way to do this (we want a query, and need to add a new export for it)
If we made auth into a component, then we'd hide away some of the installation, but that's hard for other reasons
dowski
force-pushed
the
convex-nextjs-auth-state
branch
from
9ee4cc3 to
7e42e6c
Compare
| @@ -0,0 +1,33 @@ | |||
| import { test, expect, Page } from "@playwright/test"; | |||
test-nextjs/playwright.config.ts
Outdated
| @@ -77,5 +77,7 @@ export default defineConfig({ | |||
| : "npm run dev:frontend", | |||
| url: "http://127.0.0.1:3000", | |||
| reuseExistingServer: !process.env.CI, | |||
| stdout: "ignore", // Set to "pipe" if you're debugging a failing test. | |||
There was a problem hiding this comment.
is it too loud? if this cost is just scrolling past logs seems useful to just have it?
There was a problem hiding this comment.
It adds about 100 lines of log output to a successful test run. But I guess others working on this might not even know to come in here and tweak this to debug a failing test - you're probably right that it's better to have on by default.
If the auth token doesn't validate on the Convex backend, then it's considered invalid and thus unauthenticated.
`isAuthenticatedNextJs` now checks w/ the Convex backend too.
We now unpack the isAuthenticated function in all of them.
dowski
force-pushed
the
convex-nextjs-auth-state
branch
from
5ae141b to
4f4a69f
Compare
Suggestion from review.
|
Thanks for the reviews! |
If the auth token doesn't validate on the Convex
backend, then it's considered invalid and thus
unauthenticated.
The old check just validated that there was some token
cookie but not that it was valid for use.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.