Update testing structure for dbt Labs testing support - postgres #33
Conversation
emmyoop
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
emmyoop
changed the title
emmyoop
changed the title
|
Hey @emmyoop - I just appproved the tests, looks like they're failing from this change. |
emmyoop
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
emmyoop
force-pushed
the
er/support-dbt-testing-format
branch
from
3602825 to
0846d99
Compare
emmyoop
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
There was a problem hiding this comment.
@NiallRees the CI is failing because I updated the testing folder to be located somewhere else. But the workflow itself is triggered off pull_request_target. That means the workflow code is running what exists on main - the version looking for profiles in integration_test_project even though the profiles file is now located in intgeration_tests.
We can do this iteratively where the testing folder is duplicated then another PR follows to remove the duplicated code?
There was a problem hiding this comment.
I’ll merge this if you’re confident, then want to open another dummy change PR to validate? I think we might actually need to fix some tests ourselves too
Resolve #32
This PR make a slight update to the current testing layout to allow dbt Labs to start testing this package as part of our own
release process.
I have left your current tests in place while modifying them slightly. A large portion of this PR is just renaming existing vars and folders. The actual additional functionality is rather small.
Why Do We Need These Changes
As explained in #32, by setting up tox as a standard entry-point, the Core development team at dbt Labs can include this package's integration tests (along with other popular dbt packages) as part of our continuous development & delivery of dbt.