Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Steal connection on 2nd connection attempt #2007

Closed
luckysori opened this issue May 11, 2022 · 0 comments · Fixed by #2053
Closed

Steal connection on 2nd connection attempt #2007

luckysori opened this issue May 11, 2022 · 0 comments · Fixed by #2053
Assignees

Comments

@luckysori
Copy link
Contributor

This would be an attempt at solving some of the issues described here: #1954.

@bonomat bonomat self-assigned this May 17, 2022
bonomat added a commit that referenced this issue May 17, 2022
Resolves #2007

If the same taker tries to connect twice we prioritize the second connection. This can be useful if the taker thinks he is disconnected from the maker but the maker does not
bors bot added a commit that referenced this issue May 20, 2022
2053: Steal connection r=bonomat a=bonomat


Resolves #2007

If the same taker tries to connect twice we prioritize the second connection. This can be useful if the taker thinks he is disconnected from the maker but the maker does not


2074: Revert changes to `prepare_db.sh` r=luckysori a=luckysori

With patch b899831 we modified the `prepare_db.sh` script in order to be able to define `sqlx` queries under `cfg(test)`.

This was convenient, but it turns out that the changes cause the script to trigger _complete_ recompilation of the project every time we run it.

There may be an alternative, but for the time being we revert this change. The effect is very minor: we move some test queries to a
`sqlx_test_utils` annotated with `#[allow(dead_code)]`.

Co-authored-by: Philipp Hoenisch <[email protected]>
Co-authored-by: Lucas Soriano del Pino <[email protected]>
@bors bors bot closed this as completed in c79f973 May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants