-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color field migration from RGBA #6784
Comments
I thought this would already work. Have you the |
Yes, I have Maybe your script don't support rgba(0,0,0,0.3) but support rgba(0, 0, 0, 0.3). I will see to test this. |
Hmm, now in my test everything went smoothly... It migrated the color properly. And a few hours ago it gave me an error on every try. You can feely close this, I will go for further migration. |
Sorry for the delay. I think I found what is making an error. The new Kirby color field only supports one format at a time (hex or RGB or HSL), but old Kirby colors plugin supported all formats at once. For the same field in the Layout section on one page admins often used hex colors if the color is not transparent and RGB if the color is transparent. In that case, Kirby's color field drops an error for a color format it doesn't support. So, to make the migration, the admin would need to go from field to field and manually change color to get the supported format. I reverted to the old Kirby colors plugin fields all fields with Could you do something about this? |
@mynameisfreedom I can't reproduce this still: In the blueprint I have hexFormat:
type: color
format: hex
alpha: true In the content file:
Panel loads like this: If I focus the input now and click outside again, it'll convert it to the equivalent HEX code: |
Hi team, as always your new features are great, and it is fantastic that the Color field is in the core.
Description
But I have one issue with migration from hananils/kirby-colors plugin to the new Color field. Migration to the Color field is smooth except for one thing: hananils/kirby-colors plugin used rgba color when alpha is set to true. So, at the moment it is not possible to migrate those to the Kirby Color field.
hananils/kirby-colors saved alpha: true fields in this format rgba(0,0,0,0.3) so when I migrate to new Color field there is an error for every field that used opacity. And because every Layout Builder section in my Layout Builder has a color opacity overlay option for the section background image, that field is used a lot. 🫣
Expected behavior
If you could either:
hananils/kirby-colors still work, but I doubt that will be the case for too much longer.
Maybe this is a small thing, but it would help hundreds of websites migrate smoothly to the new Color field.
Thank you in advance. 🙏
The text was updated successfully, but these errors were encountered: