Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previews 3 - Image preview class #6576

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Previews 3 - Image preview class #6576

merged 6 commits into from
Aug 15, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 25, 2024 •
edited
Loading

Description

Summary of changes

  • Adds file preview class for images

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jul 25, 2024
@distantnative distantnative self-assigned this Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Merged
@distantnative distantnative force-pushed the v5/file-previews/3-image-preview branch 2 times, most recently from de59961 to 1693b9a Compare July 25, 2024 20:42
@distantnative distantnative force-pushed the v5/file-previews/3-image-preview branch from 1693b9a to 502c5ac Compare August 6, 2024 10:52
@distantnative distantnative force-pushed the v5/file-previews/3-image-preview branch from 502c5ac to 248c544 Compare August 13, 2024 10:35
@distantnative distantnative marked this pull request as ready for review August 13, 2024 10:38
@distantnative distantnative added this to the 5.0.0-alpha.3 milestone Aug 15, 2024
@bastianallgeier bastianallgeier merged commit 295ca51 into v5/develop Aug 15, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/file-previews/3-image-preview branch August 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
5.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier