Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Merge first
Description
Summary of changes
It's finally time for the real thing and main attraction for this PR series. 🎉
This actually:
$page->renderVersionFromRequest()
for the draft detection in$app->resolve()
Reasoning
Additional context
This is the first PR where it really makes sense to test it by hand as well. All "default" previews should now work. Only custom blueprint
preview
options that point to other pages don't work yet, those will be added in the last (smaller) PRs 8 and 9.So for this PR, we can already test the expected behavior for:
Changelog
Enhancements (since alphas)
_token
query param like draft previews. This protects those previews from access by external visitors.Breaking changes
$page->isVerified()
method in favor of internal$page->renderVersionFromRequest()
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)