Improve GitHub asset upload retry algorithm

[chadwhitacre]

Seen a few times now that we can get an intermittent asset upload failure from GitHub. Do we have a retry already for that? How about it?

@rhcarvalho @iker-barriocanal Do you recall the retry conversation we had earlier? Was it around GitHub asset uploads?

[BYK]

We try up to 3 times:

craft/src/targets/github.ts

Line 389 in 03fda08

retries = 3

We can probably increase it and also add some delay?

[iker-barriocanal]

@chadwhitacre it was about asset downloads.

[rhcarvalho]

Looking at the code at

craft/src/targets/github.ts

Lines 394 to 396 in 03fda08

	if (!(err instanceof RequestError)) {
	throw err;
	}

, I am not sure if the retry logic is working as expected. @chadwhitacre's https://github.com/getsentry/publish/runs/4540082749?check_suite_focus=true#step:8:169 did have 3x 500 requests to the failed asset, but I don't see a "Reached maximum retries..." error.

We need getsentry/publish#665 to get better stack traces :)

+1 to potentially a few more retries and exponential backoff.

[AbhiPrasad]

Closing because this is pretty stale. We can re-open and revisit this later.