Releases keep failing

[BYK]

Hi,

I've been getting lightly spammed by these failures for quite a while now: https://github.com/getsentry/develop/runs/6442571103?check_suite_focus=true

Would be great to fix whatever is broken and even better, find a way for them to not mention me? 😁

/cc @chadwhitacre

[chadwhitacre]

#581 should stop the spam for you @BYK, investigating root cause of failures ...

[chadwhitacre]

No tags can describe 'sha'

[chadwhitacre]

https://stackoverflow.com/questions/6445148/git-fatalno-tags-can-describe-sha1-number

Oh! Is this related to getsentry/craft#343? Were we using annotated tags prior? Why doesn't this fail everywhere, then? Why only in this repo? I just a bunch of prepare release actions work yesterday/today with the self-hosted release. 🤔

[chadwhitacre]

getsentry/craft#343 landed ~3 months ago and failures go back ~9 months, though logs are lost past 2 months.

[chadwhitacre]

I have a local repro with latest craft. I think this is going to end up as an issue over there ...

$ craft prepare 10.0.0 --dry-run
ℹ Checking the local repository status...                                                17:57:55
ℹ Releasing version 10.0.0 from master                                                   17:57:55
ℹ Preparing to release the version: 10.0.0                                               17:57:55
ℹ [dry-run] Not creating a new release branch                                            17:57:55

 ERROR  fatal: No tags can describe '6d54d6a413b7f9aefa5812d0501de7da353885e1'.          17:57:55
Try --always, or create some tags.


  Try --always, or create some tags.
  
  at Object.action (/Users/chadwhitacre/workbench/getsentry/craft/dist/craft:625:9722)
  at cZe.exec (/Users/chadwhitacre/workbench/getsentry/craft/dist/craft:625:10034)
  at /Users/chadwhitacre/workbench/getsentry/craft/dist/craft:623:6720
  at new Promise (<anonymous>)
  at r5.handleTaskData (/Users/chadwhitacre/workbench/getsentry/craft/dist/craft:623:6609)
  at r5.<anonymous> (/Users/chadwhitacre/workbench/getsentry/craft/dist/craft:623:6234)
  at Generator.next (<anonymous>)
  at a (/Users/chadwhitacre/workbench/getsentry/craft/dist/craft:620:1523)
  at processTicksAndRejections (internal/process/task_queues.js:95:5)

$

[chadwhitacre]

Bug is in here.

$ git describe --tags --abbrev=0
fatal: No tags can describe '6d54d6a413b7f9aefa5812d0501de7da353885e1'.
Try --always, or create some tags.
$

[chadwhitacre]

Filed getsentry/craft#395, but ...

$ git tag
21.9.0

🤔

[chadwhitacre]

The commit that 21.9.0 points to is not on any branch.

$ git branch --contains 6c67e883ec9ef6e89385e03d214dfe9c3f2c995c
$

[chadwhitacre]

Looks like the release commit (carrying the tag) is expected to be on the default branch.

$ git describe --tags --abbrev=0
22.5.0
$ git branch --contains de07b479af8834d7e5d629cb152cf45ac6f02ba5
* master
$

[chadwhitacre]

#581 merged so light spam should stop @BYK. 🙏

[chadwhitacre]

Well this doesn't look good:

* commit 45cd9b19374b403ba8c6c210e21dbe26b3faf263
| Author: Chad Whitacre <[email protected]>
| Date:   Wed Sep 15 16:23:41 2021 -0400
| 
|     release: 21.9.0 (#434)
|     
|     Co-authored-by: getsentry-bot <[email protected]>
| 
* commit dcc5a06da56c35611864f33ee60e7dd433f7372f
| Author: Kamil Ogórek <[email protected]>
| Date:   Wed Sep 15 20:35:13 2021 +0200
| 
|     docs(envelopes): Update envelope header requirement (#433)
|     
|     * docs(envelopes): Update envelope header requirement
|     
|     * add a note regarding envelope header being required
|     * remove an example without envelope header
|     * fix title of one of the examples
|     
|     * Update src/docs/sdk/envelopes.mdx
|   
| * commit 6c67e883ec9ef6e89385e03d214dfe9c3f2c995c (tag: 21.9.0)
|/  Author: getsentry-bot <[email protected]>
|   Date:   Wed Sep 15 18:02:30 2021 +0000
|   
|       release: 21.9.0
| 
* commit afb3e766967813ca586d85ada5c30c858ef6dc41
| Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
| Date:   Fri Sep 10 23:21:41 2021 +0000

[chadwhitacre]

getsentry/publish#544

[chadwhitacre]

Finished this manually.

getsentry/publish#544 (comment)

[chadwhitacre]

Error: The log was not found. It may have been deleted based on retention settings.

https://github.com/getsentry/publish/runs/3613388872?check_suite_focus=true

😞

[chadwhitacre]

Alright, so it looks like we got bit by a race condition during 21.9.0 and @kamilogorek snuck in a commit between the bot's attempt and my attempt to release 21.9.0. Since this is just a docs repo and is low-risk and this is hardly a big deal (right? right!?), my plan is to retag 21.9.0 to 45cd9b1, and then retry a new release.

[chadwhitacre]

Old commit is 6c67e88 for the record, renamed tag to 21.9.0-old (still linked to GitHub's release record, added a note). 21.9.0 now points to 45cd9b1. New release run: https://github.com/getsentry/develop/actions/runs/2335084422 => getsentry/publish#1092.

[chadwhitacre]

A'ight, calling this good. ✌️