Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

docs(apis): Adding API basics #1027

Merged
merged 2 commits into from
Aug 29, 2023
Merged

docs(apis): Adding API basics #1027

merged 2 commits into from
Aug 29, 2023

Conversation

sentaur-athena
Copy link
Member

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 4:09pm

Nested resources format like `api/0/organizations/{org}/projects/` is recommended over `api/0/projects/` for readability because it gives user an understanding of resource hierarchy but they can also make the URLs too long and hard to use. So at Sentry we’re going with 3-level nesting as a hybrid solution.

Here are some possible urls for values with this resource hierarchy: organization -> project -> tag -> value
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanamatthews is there a better way to highlight a block? I used code block but this is not exactly code :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, you could put it in a Note or a quote block, but that doesn't seem to fit the content. It might be best to just make it a bulleted list and format the URLs as code, like in my suggested edit

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions to fix some grammar & spelling things as well as some other language tweaks for clarity.

src/docs/api/index.mdx Outdated Show resolved Hide resolved
src/docs/api/basics.mdx Outdated Show resolved Hide resolved
src/docs/api/basics.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
src/docs/api/design.mdx Outdated Show resolved Hide resolved
apply suggested changes

Co-authored-by: Shana Matthews <[email protected]>
@sentaur-athena sentaur-athena merged commit 3c04c0b into master Aug 29, 2023
4 checks passed
@sentaur-athena sentaur-athena deleted the athena/api-basics branch August 29, 2023 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants