User Feedback form (due: Dec 6)

[armcknight]

Description

Build the configurable UI form that captures the end user's feedback

[armcknight]

Current progress: have the form built, displaying/dismissing correctly with hiding/reshowing widget button.

Needs fixing:

• custom text field borders don't have same dimensions as default
• svg logo drawing: svg arc definitions weren't translated to cgpath arcs correctly by cursor, will have to calculate and do by hand, or potentially use PaintCodeApp if possible
• i'd like to customize the modal presentation so it appears as a free-floating dialog with rounded corners. possibly can use UIAlertController, otherwise will use a custom modal presentation.

Default	Customized

[armcknight]

Update, got the logo fixed, and got the field/button heights a little taller to match the screenshot in the docs for the web version. Did some work to get the the UITextField and UITextView inner padding equal, as by default they are annoyingly different. Also to equalize spacing between various elements.

padding	spacing

[armcknight]

This is what it will look like when there is a screenshot selected:

[armcknight]

There's an issue where the keyboard covers elements on smaller screens. There are a couple options to mitigate this, and we might take a combination of approaches:

1. change the scrollview's content size and offsets so that the portion of the screen above the keyboard is effectively the entire visible viewport for its content
2. automatically dismiss the keyboard when scrolling down, similar to how UITableView works (we could implement the whole view as a UITableView to get this for free, but I think layout would actually be more of a pain that way; cost/benefit doesn't seem worth it, unless for some reason implementing this behavior is a huge stretch for UIScrollView, which I doubt). tradeoff here is that a pan down gesture far enough will also dismiss the entire form, but maybe we decide to do away with that UX in favor of keyboard mgmt. I actually like this idea. (ETA: didn't actually have to remove the pan down gesture! 🎉)
3. add an accessory view to the keyboard with buttons to dismiss the keyboard (and also traverse the different form elements; I do this in several of my own apps, it's one of my favorite approaches, but is a screen real estate tradeoff, especially if the predictive text ribbon is also visible, which it will be for most people)
4. make the keyboard's "return" key dismiss the keyboard. should work fine in all but the text view, where we'd have to decide that it's ok to not allow users to write in multiple paragraphs

I think a combination of 1 and 2 will be the best approach. See #4590

[armcknight]

This is functionally complete. There is one polish item I know of that needs attention: when using customized outlines, the text fields are sized differently (since we explicitly use a custom CALayer instead of letting UIKit do whatever it does by default).