-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): keyboard avoidance #4590
fix(feedback): keyboard avoidance #4590
Conversation
…(feedback)/keyboard-avoidance
…(feedback)/keyboard-avoidance
…(feedback)/keyboard-avoidance
…feat(feedback)/keyboard-avoidance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat(user-feedback)/form-2 #4590 +/- ##
===========================================================================
- Coverage 90.873% 90.827% -0.047%
===========================================================================
Files 616 616
Lines 70850 70887 +37
Branches 25148 25180 +32
===========================================================================
+ Hits 64384 64385 +1
- Misses 6374 6411 +37
+ Partials 92 91 -1
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
93cfbd6 | 1238.82 ms | 1257.69 ms | 18.88 ms |
9d027bd | 1245.98 ms | 1260.66 ms | 14.68 ms |
3f265ec | 1234.46 ms | 1254.38 ms | 19.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
93cfbd6 | 22.30 KiB | 748.27 KiB | 725.96 KiB |
9d027bd | 22.30 KiB | 754.44 KiB | 732.14 KiB |
3f265ec | 22.30 KiB | 754.50 KiB | 732.20 KiB |
Previous results on branch: armcknight/feat(feedback)/keyboard-avoidance
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
168c7f2 | 1226.75 ms | 1248.79 ms | 22.04 ms |
4df9026 | 1237.73 ms | 1244.08 ms | 6.35 ms |
474b678 | 1243.63 ms | 1265.83 ms | 22.20 ms |
7d695c1 | 1226.00 ms | 1245.64 ms | 19.64 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
168c7f2 | 22.30 KiB | 756.46 KiB | 734.16 KiB |
4df9026 | 22.30 KiB | 756.46 KiB | 734.16 KiB |
474b678 | 22.30 KiB | 756.30 KiB | 734.00 KiB |
7d695c1 | 22.30 KiB | 756.41 KiB | 734.11 KiB |
…feat(feedback)/keyboard-avoidance
…feat(feedback)/keyboard-avoidance
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
01c69a6
into
armcknight/feat(user-feedback)/form-2
for #4271; #skip-changelog
fixes the issue described in #4536 (comment); the contents of the form were already in a scrollview, so this just adjusts its insets to regain visibility of all elements while the keyboard is occupying screen space
before:
before.keyboard.avoidance.fixes.mov
after:
after.keyboard.avoidance.fixes.mov