-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SwiftUI time for initial display and time for full display #4596
base: main
Are you sure you want to change the base?
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
59ea421 | 1258.83 ms | 1272.55 ms | 13.72 ms |
d257eb9 | 1206.98 ms | 1227.50 ms | 20.52 ms |
c50d363 | 1215.10 ms | 1231.82 ms | 16.72 ms |
f1d1166 | 1237.54 ms | 1256.06 ms | 18.52 ms |
0538fb6 | 1218.35 ms | 1241.36 ms | 23.01 ms |
6f4d20c | 1228.67 ms | 1238.88 ms | 10.21 ms |
407ff99 | 1225.49 ms | 1232.88 ms | 7.39 ms |
8cf5bca | 1231.33 ms | 1237.81 ms | 6.48 ms |
a90f228 | 1226.37 ms | 1248.63 ms | 22.27 ms |
0dfdaaa | 1226.88 ms | 1248.82 ms | 21.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
59ea421 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
d257eb9 | 20.76 KiB | 433.22 KiB | 412.46 KiB |
c50d363 | 20.76 KiB | 432.68 KiB | 411.92 KiB |
f1d1166 | 21.58 KiB | 630.74 KiB | 609.16 KiB |
0538fb6 | 21.58 KiB | 683.50 KiB | 661.92 KiB |
6f4d20c | 20.76 KiB | 431.71 KiB | 410.95 KiB |
407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
8cf5bca | 21.58 KiB | 671.30 KiB | 649.72 KiB |
a90f228 | 21.90 KiB | 724.12 KiB | 702.22 KiB |
0dfdaaa | 20.76 KiB | 434.56 KiB | 413.79 KiB |
Previous results on branch: feat/swiftui-ttid
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b6def0 | 1226.11 ms | 1247.20 ms | 21.10 ms |
9ef5a81 | 1234.29 ms | 1256.35 ms | 22.07 ms |
895b829 | 1232.55 ms | 1250.90 ms | 18.35 ms |
7ce0058 | 1230.49 ms | 1246.94 ms | 16.45 ms |
f6a9e2b | 1234.94 ms | 1245.60 ms | 10.66 ms |
f583fd1 | 1243.27 ms | 1258.91 ms | 15.65 ms |
f38e16a | 1237.13 ms | 1262.76 ms | 25.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8b6def0 | 22.30 KiB | 750.46 KiB | 728.16 KiB |
9ef5a81 | 22.30 KiB | 750.46 KiB | 728.16 KiB |
895b829 | 22.30 KiB | 750.46 KiB | 728.16 KiB |
7ce0058 | 22.30 KiB | 750.46 KiB | 728.16 KiB |
f6a9e2b | 22.30 KiB | 750.46 KiB | 728.16 KiB |
f583fd1 | 22.30 KiB | 750.46 KiB | 728.16 KiB |
f38e16a | 22.30 KiB | 750.46 KiB | 728.16 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4596 +/- ##
=============================================
- Coverage 91.011% 90.940% -0.072%
=============================================
Files 617 614 -3
Lines 70936 70972 +36
Branches 25319 25330 +11
=============================================
- Hits 64560 64542 -18
- Misses 6284 6338 +54
Partials 92 92
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
📜 Description
Track time for initial display and time for full display in SwiftUI
💚 How did you test it?
UI Test and sample
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps