Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SwiftUI time for initial display and time for full display #4596

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

brustolin
Copy link
Contributor

📜 Description

Track time for initial display and time for full display in SwiftUI

💚 How did you test it?

UI Test and sample

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Dec 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 45623f3

Copy link

github-actions bot commented Dec 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.22 ms 1249.19 ms 20.96 ms
Size 22.31 KiB 756.73 KiB 734.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
59ea421 1258.83 ms 1272.55 ms 13.72 ms
d257eb9 1206.98 ms 1227.50 ms 20.52 ms
c50d363 1215.10 ms 1231.82 ms 16.72 ms
f1d1166 1237.54 ms 1256.06 ms 18.52 ms
0538fb6 1218.35 ms 1241.36 ms 23.01 ms
6f4d20c 1228.67 ms 1238.88 ms 10.21 ms
407ff99 1225.49 ms 1232.88 ms 7.39 ms
8cf5bca 1231.33 ms 1237.81 ms 6.48 ms
a90f228 1226.37 ms 1248.63 ms 22.27 ms
0dfdaaa 1226.88 ms 1248.82 ms 21.94 ms

App size

Revision Plain With Sentry Diff
59ea421 22.85 KiB 413.45 KiB 390.60 KiB
d257eb9 20.76 KiB 433.22 KiB 412.46 KiB
c50d363 20.76 KiB 432.68 KiB 411.92 KiB
f1d1166 21.58 KiB 630.74 KiB 609.16 KiB
0538fb6 21.58 KiB 683.50 KiB 661.92 KiB
6f4d20c 20.76 KiB 431.71 KiB 410.95 KiB
407ff99 20.76 KiB 427.87 KiB 407.10 KiB
8cf5bca 21.58 KiB 671.30 KiB 649.72 KiB
a90f228 21.90 KiB 724.12 KiB 702.22 KiB
0dfdaaa 20.76 KiB 434.56 KiB 413.79 KiB

Previous results on branch: feat/swiftui-ttid

Startup times

Revision Plain With Sentry Diff
8b6def0 1226.11 ms 1247.20 ms 21.10 ms
9ef5a81 1234.29 ms 1256.35 ms 22.07 ms
895b829 1232.55 ms 1250.90 ms 18.35 ms
7ce0058 1230.49 ms 1246.94 ms 16.45 ms
f6a9e2b 1234.94 ms 1245.60 ms 10.66 ms
f583fd1 1243.27 ms 1258.91 ms 15.65 ms
f38e16a 1237.13 ms 1262.76 ms 25.62 ms

App size

Revision Plain With Sentry Diff
8b6def0 22.30 KiB 750.46 KiB 728.16 KiB
9ef5a81 22.30 KiB 750.46 KiB 728.16 KiB
895b829 22.30 KiB 750.46 KiB 728.16 KiB
7ce0058 22.30 KiB 750.46 KiB 728.16 KiB
f6a9e2b 22.30 KiB 750.46 KiB 728.16 KiB
f583fd1 22.30 KiB 750.46 KiB 728.16 KiB
f38e16a 22.30 KiB 750.46 KiB 728.16 KiB

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 90.14085% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.940%. Comparing base (be4734f) to head (45623f3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Sentry/SentryTimeToDisplayTracker.m 54.545% 5 Missing ⚠️
.../Sentry/SentryUIViewControllerPerformanceTracker.m 90.000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4596       +/-   ##
=============================================
- Coverage   91.011%   90.940%   -0.072%     
=============================================
  Files          617       614        -3     
  Lines        70936     70972       +36     
  Branches     25319     25330       +11     
=============================================
- Hits         64560     64542       -18     
- Misses        6284      6338       +54     
  Partials        92        92               
Files with missing lines Coverage Δ
SentryTestUtils/ClearTestState.swift 85.714% <100.000%> (ø)
Sources/Sentry/SentryHub.m 99.065% <100.000%> (-0.007%) ⬇️
...rces/Sentry/SentryPerformanceTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryProfiler.mm 89.000% <100.000%> (ø)
...yProfilerTests/SentryAppLaunchProfilingTests.swift 100.000% <100.000%> (ø)
...ce/SentryPerformanceTrackingIntegrationTests.swift 100.000% <100.000%> (ø)
...iewController/SentryTimeToDisplayTrackerTest.swift 100.000% <100.000%> (ø)
...entryUIViewControllerPerformanceTrackerTests.swift 99.012% <100.000%> (ø)
Tests/SentryTests/SentryHubTests.swift 98.872% <100.000%> (-0.004%) ⬇️
Tests/SentryTests/SentrySDKTests.swift 96.696% <100.000%> (ø)
... and 2 more

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4734f...45623f3. Read the comment docs.

@brustolin brustolin marked this pull request as ready for review December 5, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants