Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add direct branch cloning for fastlane match #4597

Merged
merged 2 commits into from
Dec 10, 2024
+37 −6
Merged

chore(ci): add direct branch cloning for fastlane match #4597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38f937a
chore(ci): add direct branch cloning for fastlane match
philprime Dec 4, 2024
5809332
docs: add comments to explain reason for direct branch clone
philprime Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ platform :ios do
sync_code_signing(
type: "appstore",
readonly: true,
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip"]
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip"],

# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
philprime marked this conversation as resolved.
Show resolved Hide resolved
)

build_app(
Expand All @@ -107,7 +112,12 @@ platform :ios do
sync_code_signing(
type: "development",
readonly: true,
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip"]
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip"],

# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
)

build_app(
Expand All @@ -129,7 +139,12 @@ platform :ios do
sync_code_signing(
type: "development",
readonly: true,
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip", "io.sentry.iOS-Swift-UITests.xctrunner"]
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip", "io.sentry.iOS-Swift-UITests.xctrunner"],

# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
)

# don't use gym here because it always appends a "build" command which fails, since this is a test target not configured for running
Expand All @@ -147,7 +162,13 @@ platform :ios do
sync_code_signing(
type: "development",
readonly: true,
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip", "io.sentry.iOS-Benchmarking.xctrunner"]
app_identifier: ["io.sentry.sample.iOS-Swift", "io.sentry.sample.iOS-Swift.Clip", "io.sentry.iOS-Benchmarking.xctrunner"],


# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
)

build_app(
Expand Down Expand Up @@ -258,7 +279,12 @@ platform :ios do
sync_code_signing(
type: "development",
readonly: true,
app_identifier: ["io.sentry.cocoa.perf-test-app-plain"]
app_identifier: ["io.sentry.cocoa.perf-test-app-plain"],

# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
)

build_app(
Expand All @@ -283,7 +309,12 @@ platform :ios do
sync_code_signing(
type: "development",
readonly: true,
app_identifier: ["io.sentry.cocoa.perf-test-app-sentry"]
app_identifier: ["io.sentry.cocoa.perf-test-app-sentry"],

# Directly cloning the branch instead of using a shallow clone fixes the rare error:
# fatal: a branch named 'master' already exists in GitHub Action workflows.
git_branch: "master",
clone_branch_directly: true
)

build_app(
Expand Down
Loading