-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): iteration #4600
Conversation
…feedback)/ui-tests
…feedback)/ui-tests
…feedback)/ui-tests
…feedback)/ui-tests
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
=============================================
- Coverage 90.882% 90.868% -0.014%
=============================================
Files 617 617
Lines 71025 71026 +1
Branches 25316 25316
=============================================
- Hits 64549 64540 -9
- Misses 6383 6394 +11
+ Partials 93 92 -1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
869ab7e | 1230.36 ms | 1255.49 ms | 25.13 ms |
8c9d1d4 | 1229.35 ms | 1251.04 ms | 21.69 ms |
2cf1b84 | 1221.10 ms | 1230.34 ms | 9.24 ms |
da2f43e | 1228.27 ms | 1251.52 ms | 23.25 ms |
72c8d84 | 1269.98 ms | 1273.78 ms | 3.80 ms |
b34716f | 1230.45 ms | 1242.53 ms | 12.09 ms |
42ef6ba | 1208.27 ms | 1214.63 ms | 6.37 ms |
ed68562 | 1238.45 ms | 1251.57 ms | 13.12 ms |
596ccc1 | 1230.85 ms | 1244.24 ms | 13.39 ms |
0af45a9 | 1225.75 ms | 1245.38 ms | 19.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
869ab7e | 20.76 KiB | 432.88 KiB | 412.11 KiB |
8c9d1d4 | 21.58 KiB | 706.97 KiB | 685.39 KiB |
2cf1b84 | 20.76 KiB | 431.91 KiB | 411.15 KiB |
da2f43e | 21.58 KiB | 542.38 KiB | 520.80 KiB |
72c8d84 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
b34716f | 22.30 KiB | 749.83 KiB | 727.53 KiB |
42ef6ba | 21.58 KiB | 417.86 KiB | 396.28 KiB |
ed68562 | 22.84 KiB | 403.24 KiB | 380.39 KiB |
596ccc1 | 22.84 KiB | 401.44 KiB | 378.60 KiB |
0af45a9 | 21.58 KiB | 631.19 KiB | 609.61 KiB |
Previous results on branch: armcknight/feat(user-feedback)/iteration
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b569bcc | 1230.92 ms | 1246.76 ms | 15.84 ms |
411eac0 | 1238.68 ms | 1257.22 ms | 18.54 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b569bcc | 22.30 KiB | 756.53 KiB | 734.23 KiB |
411eac0 | 22.30 KiB | 756.41 KiB | 734.11 KiB |
)" This reverts commit 9202018.
None of the test failures are relevant to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixing up some loose ends and writing more tests #4271; #skip-changelog