Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS warning of missing method channel callback setReplayConfig #2478

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Dec 10, 2024

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (9a604e8) to head (6f76585).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
+ Coverage   86.92%   91.39%   +4.46%     
==========================================
  Files         264       87     -177     
  Lines        9376     3032    -6344     
==========================================
- Hits         8150     2771    -5379     
+ Misses       1226      261     -965     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 467.44 ms 557.31 ms 89.87 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e083bb 327.96 ms 381.39 ms 53.43 ms
4829ad3 381.55 ms 455.45 ms 73.90 ms
9a604e8 470.65 ms 485.90 ms 15.24 ms
a40bb7c 477.10 ms 553.90 ms 76.80 ms
0ceb89c 304.57 ms 357.18 ms 52.61 ms
ebfead1 298.44 ms 374.28 ms 75.84 ms
f9d18f3 430.94 ms 497.59 ms 66.65 ms
25161f4 353.98 ms 431.94 ms 77.96 ms
732a7b4 371.98 ms 423.19 ms 51.21 ms
d7758e8 300.12 ms 349.88 ms 49.76 ms

App size

Revision Plain With Sentry Diff
6e083bb 5.94 MiB 6.97 MiB 1.03 MiB
4829ad3 6.33 MiB 7.26 MiB 943.11 KiB
9a604e8 6.49 MiB 7.57 MiB 1.08 MiB
a40bb7c 6.52 MiB 7.61 MiB 1.09 MiB
0ceb89c 5.94 MiB 6.95 MiB 1.01 MiB
ebfead1 6.06 MiB 7.03 MiB 989.24 KiB
f9d18f3 6.15 MiB 7.13 MiB 1000.49 KiB
25161f4 6.27 MiB 7.20 MiB 960.44 KiB
732a7b4 6.33 MiB 7.27 MiB 954.02 KiB
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.31 ms 1272.82 ms 31.51 ms
Size 8.38 MiB 9.78 MiB 1.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
09c1f55 1258.11 ms 1280.45 ms 22.34 ms
613760b 1263.10 ms 1277.27 ms 14.16 ms
2e93bab 1237.08 ms 1258.41 ms 21.33 ms
e0f6628 1250.57 ms 1274.86 ms 24.29 ms
0a23f98 1252.98 ms 1276.76 ms 23.78 ms
955541a 1230.22 ms 1252.96 ms 22.73 ms
6078ddc 1207.84 ms 1224.10 ms 16.27 ms
3f3ef0b 1223.73 ms 1237.67 ms 13.94 ms
3de8b9b 1234.22 ms 1251.94 ms 17.72 ms
3f23617 1261.93 ms 1286.10 ms 24.17 ms

App size

Revision Plain With Sentry Diff
09c1f55 8.38 MiB 9.74 MiB 1.36 MiB
613760b 8.15 MiB 9.13 MiB 1000.46 KiB
2e93bab 8.38 MiB 9.73 MiB 1.36 MiB
e0f6628 8.32 MiB 9.50 MiB 1.18 MiB
0a23f98 8.10 MiB 9.18 MiB 1.08 MiB
955541a 8.28 MiB 9.34 MiB 1.06 MiB
6078ddc 8.33 MiB 9.40 MiB 1.07 MiB
3f3ef0b 8.32 MiB 9.38 MiB 1.05 MiB
3de8b9b 8.28 MiB 9.34 MiB 1.06 MiB
3f23617 8.16 MiB 9.17 MiB 1.01 MiB

@vaind vaind marked this pull request as ready for review December 11, 2024 06:27
@vaind vaind merged commit 20a5bce into main Dec 11, 2024
53 checks passed
@vaind vaind deleted the fix/ios-warning-setreplayconfig branch December 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants