Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_unique_updates Initial commit #1622

Merged
merged 6 commits into from
Feb 25, 2024
Merged

get_unique_updates Initial commit #1622

merged 6 commits into from
Feb 25, 2024

Conversation

TraceyC77
Copy link
Contributor

Summary

Script which can take the markdown output of worklog.py and
output one entry per package using the highest version

Test Plan

  • Examined output sent to stdout and output written to file to ensure data is correct
  • Ran automated test from common/perl
❯ prove -v get_unique_updates/t/*.t                                                                                                             
get_unique_updates/t/get_unique_updates.t .. 
# Seeded srand with seed '20240214' from local date.
1..6
ok 1 - Module loads correctly.
ok 2 - Markdown file passes file check
ok 3 - Text file fails file check
ok 4 - Entry for package with 2 versions has highest value
ok 5 - Entry for package with 3 versions has highest version
test looking for /home/tracey/packaging/packages/common/perl/get_unique_updates/t/../t/data/markdown_output.md
ok 6 - Output file is written and has expected number of packages
ok
All tests successful.
Files=1, Tests=6,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.06 cusr  0.01 csys =  0.08 CPU)
Result: PASS

Checklist

  • Package was built and tested against unstable N/A

@TraceyC77 TraceyC77 force-pushed the get_unique_updates_script branch from b93acbd to d07bfeb Compare February 16, 2024 19:43
Script which can take the markdown output of worklog.py and
 output one entry per package using the highest version
@TraceyC77 TraceyC77 force-pushed the get_unique_updates_script branch from d07bfeb to 4ec1c00 Compare February 18, 2024 22:56
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't actually test this as is (see the comment on Modern::Perl being required) -- please advise.

common/perl/README Outdated Show resolved Hide resolved
common/perl/get_unique_updates/get_unique_updates.pl Outdated Show resolved Hide resolved
@TraceyC77 TraceyC77 requested a review from ermo February 22, 2024 02:50
@TraceyC77
Copy link
Contributor Author

@ermo Could you please re-review this? I'd like to get it merged before the next sync and OC mailing. Thanks.

@ermo
Copy link
Contributor

ermo commented Feb 25, 2024

@ermo Could you please re-review this? I'd like to get it merged before the next sync and OC mailing. Thanks.

See unresolved conversation above. I still see the same issue, and I'm not sure if this is PEBKAC so I apologise in advance for being fairly clueless here...

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now IMO.

@TraceyC77
Copy link
Contributor Author

If it's approved, please merge?

@ermo ermo merged commit 57f85a9 into main Feb 25, 2024
2 checks passed
@davidjharder davidjharder deleted the get_unique_updates_script branch May 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants