Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worklog.py: add -F/--follow option that follows the log #1737

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Feb 25, 2024

Summary

Add an option that prints build log entries as soon as they are available. This works similarly to the familiar options in tail.

Test Plan

./worklog.py builds -F now

Checklist

  • (N/A) Package was built and tested against unstable

@silkeh silkeh requested a review from ermo March 7, 2024 19:53
ermo
ermo previously approved these changes Mar 11, 2024
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of like this. =)

... however, it needs a rebase @silkeh ?

**Summary**

Add an option that prints build log entries as soon as they are available.
This works similarly to the familiar options in `tail`.
@silkeh
Copy link
Member Author

silkeh commented Mar 20, 2024

@ermo: rebased! I also updated the script so the printing goes line by line, which is very useful for the updates command as you can now see the actual progress!

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason this shouldn't go in as-is.

I do feel we need a note on the accepted date format with an example, but I am unsure how to do this with the current argparser setup...

@silkeh silkeh merged commit 5a2cc20 into main Mar 21, 2024
2 checks passed
ermo added a commit that referenced this pull request Mar 28, 2024
…tput (#1935)

**Summary**

Improve the worklog build output with:

- An emoji indicating the job status.
- The build duration when the job is finished.
- The comment given to the bulid.

Depends on #1737 and updates to the build server.

**Test Plan**

Against a local build log:

![image](https://github.com/getsolus/packages/assets/5798032/ad162c3d-bf78-49d6-967d-b87d08dafbf7)

**Checklist**

- [x] ~~Package was built and tested against unstable~~
@davidjharder davidjharder deleted the worklog-tail branch May 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants