Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Rework package-publish-safety-catches.sh to use the CI checks #2050

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Mar 31, 2024

Summary

Run the CI checks in the safety catches instead of using a separate implementation.

Depends on #2038. Resolves #1496.

Test Plan

Run go-task run-safety-catches on a branch that is ahead of main (with these changes checked out):

afbeelding

Checklist

  • Package was built and tested against unstable

silkeh added 3 commits April 3, 2024 11:24
**Summary**

Add flags for:

- Only showing the results, no summaries about what is checked.
- Exiting with an error code when warnings are found.
**Summary**

Run the CI checks in the safety catches instead of using a separate implementation.
@silkeh silkeh force-pushed the replace-safety-catches branch from 7b5fe02 to 94d54fc Compare April 3, 2024 09:24
@silkeh silkeh marked this pull request as ready for review April 3, 2024 12:17
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will be quite useful.

Let's get it in early for this cycle so we can address any potential fallout early (risk is low, but better safe than sorry etc. etc.)

@ermo ermo merged commit bbdeaa2 into main Apr 19, 2024
2 checks passed
@ermo ermo deleted the replace-safety-catches branch April 19, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ensure that the git commit hook safety catch stuff in Taskfile.yml shows up in terminal output
2 participants