CI/hooks: Bring py3 scripts under test per request #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermo
added
Topic: Plumbing
silkeh
requested changes
Apr 7, 2024
**Summary** Ensure that all available common/Scripts/*.py files get linted by flake8 as part of commits. This way, new python3 scripts will automagically be linted on addition. Signed-off-by: Rune Morling <[email protected]>
ermo
force-pushed
the
CI-add-py3-common-Scripts
branch
from
0cc3f3a to
c0981ac
Compare
**Summary** @silkeh suggests that this change will also trigger the CI, so is worth- while for several reasons. Signed-off-by: Rune Morling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1st attempt at ensuring that all available common/Scripts/*.py files get linted as part of commits.
Test Plan
Run
go-task init && go-task checkand observe that nothing blows up when git hooks are run.Checklist
- [x] Package was built and tested against unstable