Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python3-pylast stack, and fix python-trove-classifiers issue #4490

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Nov 29, 2024

Summary

Update the python3-pylast build stack, down from python-packaging, to fix an issue with python-trove-classifiers that also affected yt-dlp. This also introduces Python 3.13 support.

Update python3-pylast to 5.3.0.

Remove the workaround from yt-dlp.

Test Plan

  • Successfully built all the packages in the stack without workaround
  • Played some last.fm songs in lollypop

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged (Write an appropriate message in the Summary section)

@davidjharder
Copy link
Member

yt-dlp is going to need a rebase now

**Summary**

Release notes available [here](https://github.com/pypa/packaging/releases/tag/24.2)

Signed-off-by: Thomas Staudinger <[email protected]>
**Summary**

Changes:
- Add support for Python 3.13
- Add type annotations to methods that take timestamp parameter
- Double read timeout to fix 'The read operation timed out'
- Fix incorrect docstrings

Signed-off-by: Thomas Staudinger <[email protected]>
**Summary**

No longer needed after `python-trove-classifier` update

Signed-off-by: Thomas Staudinger <[email protected]>
@Staudey
Copy link
Member Author

Staudey commented Dec 4, 2024

Done

Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@malfisya malfisya merged commit 43de8cd into getsolus:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants