Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ypkg: Add patch to fix Python builds with spaces in dir name #4558

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Dec 10, 2024

Summary

Directories with spaces in their name previously broke Python builds. Discovered while trying to package an anoise update.

Test Plan

Successfully built new anoise version

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged (Write an appropriate message in the Summary section)

ermo
ermo previously approved these changes Dec 10, 2024
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo marked this pull request as draft December 10, 2024 23:29
**Summary**

Directories with spaces in their name previously broke Python builds.
Discovered while trying to package an `anoise` update.

Signed-off-by: Thomas Staudinger <[email protected]>
@Staudey Staudey marked this pull request as ready for review December 10, 2024 23:35
@Staudey
Copy link
Member Author

Staudey commented Dec 10, 2024

Okay, done, now building from newest commit instead of using another patch

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo merged commit 57c55d4 into getsolus:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants