Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Excalidraw - a virtual collaborative whiteboard tool #1538

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

dennysubke
Copy link
Contributor

@dennysubke dennysubke commented Sep 25, 2024

App Submission

Excalidraw - a virtual collaborative whiteboard tool

...

256x256 SVG icon

logo - Kopie

...

Gallery images

seO3Bjj - Imgur

aBhrCkg - Imgur

q71BAIJ - Imgur

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

Copy link

❌   Linting failed with 1 error and 2 warnings   ❌

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
⚠️ excalidraw/docker-compose.yml Invalid image tag "latest":
Images should not use the "latest" tag
excalidraw/docker-compose.yml Invalid image architectures for image "excalidraw/excalidraw:latest@sha256:fae667864717a415e7474b5f757ffb50e63a81cfc1a2fbcf905ecbd137d0dbba":
The image "excalidraw/excalidraw:latest@sha256:fae667864717a415e7474b5f757ffb50e63a81cfc1a2fbcf905ecbd137d0dbba" does not support the architectures "arm64" and "amd64". Please make sure that the image supports both architectures.
⚠️ excalidraw/umbrel-app.yml "icon" and "gallery" needs to be empty for new app submissions:
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Oct 3, 2024

Thanks for this one as well @dennysubke!

I've written the same in your other PR, but just noting here as well that we've got our heads down on some other aspects of the codebase, but we have this on our radar and will get to it soon.

@sharknoon
Copy link
Contributor

sharknoon commented Oct 3, 2024

Thank you @dennysubke for another great app submission. Unfortunately this image only supports the amd64 platform. We have a strikt rule, that all apps MUST run on arm64 as well as amd64. Maybe in the future this will change with emulation, but right now umbrelOS has no QEMU built-in.

@nmfretz I propose we convert this PR to an Draft for now and add a label called missing-arm64

@nmfretz
Copy link
Contributor

nmfretz commented Oct 15, 2024

@nmfretz I propose we convert this PR to an Draft for now and add a label called missing-arm64

Ah, ya that's unfortunate about the missing architecture. Looking at Excalidraw's GitHub issues, it seems like there is no interest from them on supporting an arm image: https://github.com/excalidraw/excalidraw/issues?q=arm%20support

@dennysubke if you end up opening another issue on Excalidraw's repo to request official arm images, please let us know and we'll drop by the Issue to +1.

@nmfretz nmfretz changed the title App Submission: Excalidraw - a virtual collaborative whiteboard tool [Missing arm64 support] - App Submission: Excalidraw - a virtual collaborative whiteboard tool Oct 15, 2024
@nmfretz nmfretz marked this pull request as draft October 15, 2024 02:40
@nmfretz nmfretz added the missing arm64 support Docker image doesn’t support required arm64 architecture label Oct 15, 2024
@nmfretz nmfretz changed the title [Missing arm64 support] - App Submission: Excalidraw - a virtual collaborative whiteboard tool App Submission: Excalidraw - a virtual collaborative whiteboard tool Oct 15, 2024
@dennysubke
Copy link
Contributor Author

dennysubke commented Oct 15, 2024

@nmfretz Thanks for the heads-up! I'll open an issue on Excalidraw's repo and let you know once it's done so the community can support the request. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing arm64 support Docker image doesn’t support required arm64 architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants