Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot more test files to cover more of the code in the package #26

Open
sckott opened this issue Jan 25, 2024 · 3 comments
Open

A lot more test files to cover more of the code in the package #26

sckott opened this issue Jan 25, 2024 · 3 comments
Assignees
Labels
medium priority Important but not urgent, implement soon v2.0 Should be implemented in PROOF v2.0
Milestone

Comments

@sckott
Copy link
Member

sckott commented Jan 25, 2024

Right now it's difficult to know what types of jobs I need to submit to a cromwell server to hit the various pieces of code in the package. Maybe we just need a few complex WDL/json files, or possibly many of them doing different things?

Gather from @vortexing and @sitapriyamoorthi

@sckott sckott self-assigned this Jan 25, 2024
@sckott sckott added this to the v4 milestone Jan 31, 2024
@vortexing vortexing moved this to Todo in PROOF Maintenance Mar 21, 2024
@tefirman tefirman modified the milestones: v4, PROOF v2.0 Jul 30, 2024
@tefirman tefirman added medium priority Important but not urgent, implement soon v2.0 Should be implemented in PROOF v2.0 labels Jul 30, 2024
@tefirman
Copy link
Member

tefirman commented Jul 30, 2024

Some of the WILDS WDL scripts would probably be ideal for these kinds of tests. Definitely important and feels like this package won't change much in v2.0, but similar to CRAN submission, the effort seems a little high for v1.X. Very open to moving this up to v1.2 or v1.3 if people feel strongly, but setting as v2.0 for now.

@sitapriyamoorthi
Copy link

This is definitely something we should work on to test the limits of PROOF v1 or v2. Its fair to label it as a medium priority but testing the limits of Cromwell integration will be crucial. WILDS WDL scripts or the complex one we are running for single cell should be good. But need to chalk out a plan that tests particular sections of PROOF very specifically would be important.

@sckott
Copy link
Member Author

sckott commented Jul 30, 2024

Note this is very much related to #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Important but not urgent, implement soon v2.0 Should be implemented in PROOF v2.0
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants