Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission #28

Open
3 tasks
sckott opened this issue Jan 31, 2024 · 2 comments
Open
3 tasks

CRAN submission #28

sckott opened this issue Jan 31, 2024 · 2 comments
Labels
medium priority Important but not urgent, implement soon v2.0 Should be implemented in PROOF v2.0
Milestone

Comments

@sckott
Copy link
Member

sckott commented Jan 31, 2024

blockers/pre-reqs

  • should it go to cran? if not, close this
  • currently depending on a dev version of package vcr that Scott maintains. can not submit a package to cran that depends on a package that is not on CRAN, Bioconductor or a CRAN like repository
  • make changes that will smooth a cran submission:
    • they want some egs to actually run, give em some even if dummy egs
    • make sure no tests will run that may break
    • run url checker
    • run checks on r-hub and winbuilder
@vortexing vortexing moved this to Todo in PROOF Maintenance Mar 21, 2024
@tefirman tefirman added low priority Not urgent or critical, implement whenever v2.0 Should be implemented in PROOF v2.0 labels Jul 30, 2024
@tefirman tefirman added this to the PROOF v2.0 milestone Jul 30, 2024
@tefirman tefirman added medium priority Important but not urgent, implement soon and removed low priority Not urgent or critical, implement whenever labels Jul 30, 2024
@tefirman
Copy link
Member

Love this idea, definitely think it belongs in CRAN! I don't see this package changing much in v2.0, so I wonder if this is worth doing before v2.0? Unfortunately, the effort for submission seems kinda high, so I set it as v2.0, but I'm open to moving it to v1.X if people feel strongly about it.

@sckott
Copy link
Member Author

sckott commented Jul 30, 2024

Thanks Taylor. There's one kinda big thing to think about though wrt cran and this pkg. If we move away from Shiny for the proof front-end, then we won't be dog-fooding this package and proofr anymore; and if we're not dog-fooding these pkgs anymore, do we keep maintaining them (the best tools seem to be made by people that use them themselves; e.g., githubbers use github to build github)? Maybe FH users will still use these R packages even if we aren't using them? But maybe not. TLDR: I think hold off on CRAN for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Important but not urgent, implement soon v2.0 Should be implemented in PROOF v2.0
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants