Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cromwell_logs -- download all error/output logs in a zip file? #40

Open
tefirman opened this issue May 30, 2024 · 5 comments
Open

cromwell_logs -- download all error/output logs in a zip file? #40

tefirman opened this issue May 30, 2024 · 5 comments
Labels
enhancement New feature or request medium priority Important but not urgent, implement soon v1.3 Should be implemented in PROOF v1.3
Milestone

Comments

@tefirman
Copy link
Member

Brief description of the problem:

  • Troubleshooting/debugging a WDL script is currently a bit difficult with PROOF.
  • PROOF does a good job of pointing to the location of output/error logs in rhino, but that still requires logging in to rhino.
  • Might be easier to group all of those logs together in a zip file and have the user download them to their local machine.
  • Could eventually be a button on PROOF, but felt like the core functionality needs to occur more upstream.
@tefirman tefirman added the enhancement New feature or request label May 30, 2024
@sckott
Copy link
Member

sckott commented Jul 8, 2024

@tefirman Okay if I take this?

Hm, I don't think the actual logs being returned is part of the Cromwell REST API. But maybe I'm missing something. Do you know Taylor if logs can be returned?

@tefirman
Copy link
Member Author

tefirman commented Jul 8, 2024

@sckott, that would be awesome if you don't mind! You're right, unfortunately Cromwell only returns the location of the logs, not the logs themselves, so this would require some manuevering, not entirely sure how though.

@sckott
Copy link
Member

sckott commented Jul 8, 2024

Yeah I don't know how easily we can make this happen. I'll take a look see

@sckott
Copy link
Member

sckott commented Jul 9, 2024

@dtenenba AFAICT Cromwell API doesn't allow one to fetch the contents of workflow log files, but only the location (path). Do you think there's an easy enough way to securely fetch the log file contents in addition to the location of said file?

It seems there is a way via configuration to send log files somewhere else so they don't get cleaned up https://cromwell.readthedocs.io/en/latest/Logging/#workflow-logs but that still leaves the problem of fetching those log files. Perhaps it'd be easier though to fetch them for the client (e.g., PROOF app or an R client) if log files were pushed into an S3 bucket for example rather than somewhere else on the cluster

@tefirman tefirman added the medium priority Important but not urgent, implement soon label Jul 24, 2024
@tefirman tefirman modified the milestones: rcromwell v3.3, v3.3, PROOF v1.1 Jul 24, 2024
@tefirman tefirman added the v1.1 Should be implemented in PROOF v1.1 label Jul 30, 2024
@sckott
Copy link
Member

sckott commented Aug 7, 2024

@tefirman We discussed this with Dan yeah? Or maybe not?

@tefirman tefirman added v1.3 Should be implemented in PROOF v1.3 and removed v1.1 Should be implemented in PROOF v1.1 labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Important but not urgent, implement soon v1.3 Should be implemented in PROOF v1.3
Projects
None yet
Development

No branches or pull requests

2 participants