Add newTextureWithDescriptor:iosurface:plane:
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Jun 19, 2019
| @@ -1380,6 +1380,10 @@ type MTLNewRenderPipelineStateWithReflectionCompletionHandler = extern fn(render | |||
| type MTLNewComputePipelineStateCompletionHandler = extern fn(computePipelineState: id, error: id); | |||
| type MTLNewComputePipelineStateWithReflectionCompletionHandler = extern fn(computePipelineState: id, reflection: id, error: id);*/ | |||
|
|
|||
| #[derive(Debug, Copy, Clone)] | |||
| pub enum _IOSurface { } | |||
There was a problem hiding this comment.
We should probably declare it as a full-featured foreign_obj_type
| @@ -1665,6 +1669,14 @@ impl DeviceRef { | |||
| pub fn new_texture(&self, descriptor: &TextureDescriptorRef) -> Texture { | |||
| unsafe { msg_send![self, newTextureWithDescriptor: descriptor] } | |||
| } | |||
|
|
|||
| pub fn new_texture_with_surface_plane(&self, descriptor: &TextureDescriptorRef, iosurface: IOSurfaceRef, plane: NSUInteger) -> Texture { | |||
There was a problem hiding this comment.
like with other ref arguments, we should use &IOSurfaceRef
I suppose this is directly related to making IOSurface to be a real foreign type
There was a problem hiding this comment.
Yeah I mentioned it briefly in #38, should we be using https://github.com/servo/core-foundation-rs/blob/37b82c5564428818726887e7a17450c8bc3227d0/io-surface/src/lib.rs#L19?
|
How is this PR going? If we want to use |
|
We don't want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.