Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leap forward #1

Open
ofirgall opened this issue Aug 2, 2022 · 5 comments
Open

leap forward #1

ofirgall opened this issue Aug 2, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@ofirgall
Copy link

ofirgall commented Aug 2, 2022

Why can't we leap both ways?

@ggandor
Copy link
Owner

ggandor commented Aug 2, 2022

It was simpler to implement :) (I threw the original gist together literally in an hour or less.)

@ggandor ggandor added the enhancement New feature or request label Aug 2, 2022
@CharlesChiuGit
Copy link

CharlesChiuGit commented Feb 10, 2023

Hope this feature is still been working on!
I really like leap and with the power of syntax tree, leap would be more powerful!

@jul-o
Copy link

jul-o commented Mar 18, 2023

Would something like that be a good result?
image

I added children leaping to my local clone of the project, but I am not sure I like it too much, as there is a lot of visual clutter as a result. Maybe some sort of filtering might be good (or maybe only picking the first child recursively, along with the current node's siblings might be a good idea).

Also, I used a simple DFS to scan the children, and as a result, deep nodes of the first child are prioritized over the second child, and so on. I would rather have a BFS, but I do not really have the time to figure that ou right now.

If the project is open to PRs, and my implementation seems good to you, please let me know. It would be my pleasure to submit that feature, along with an optional parameter that enables forward leaping.

@CharlesChiuGit
Copy link

Would something like that be a good result? image

I added children leaping to my local clone of the project, but I am not sure I like it too much, as there is a lot of visual clutter as a result. Maybe some sort of filtering might be good (or maybe only picking the first child recursively, along with the current node's siblings might be a good idea).

Also, I used a simple DFS to scan the children, and as a result, deep nodes of the first child are prioritized over the second child, and so on. I would rather have a BFS, but I do not really have the time to figure that ou right now.

If the project is open to PRs, and my implementation seems good to you, please let me know. It would be my pleasure to submit that feature, along with an optional parameter that enables forward leaping.

That looks cool!

@adamsitar
Copy link

so what happened to the leap forward feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants