Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined order of filters #117

Open
ghost91- opened this issue Dec 19, 2021 · 0 comments
Open

Defined order of filters #117

ghost91- opened this issue Dec 19, 2021 · 0 comments
Labels
enhancement New feature or request filter effects

Comments

@ghost91-
Copy link
Contributor

Description

Currently, the order in which filters are applied is more or less random because it's just the order in which Object.values(this.filters) returns the filters. This may lead to situations where the same set of filters looks differently in different instances because they do not have the same order.

The solution to this is to define some sort of order in which filters are applied. As a first step, it might make sense to just hard code the most natural order of filter types. And filters of the same type need to be sorted by another property. As a first attempt, the id of the filter could be used.

Later one, the order could be adjustable by users.

Context

#116 (comment)

@ghost91- ghost91- added the enhancement New feature or request label Dec 19, 2021
@ghost91- ghost91- added this to the Foundry V10 Release milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request filter effects
Projects
None yet
Development

No branches or pull requests

1 participant