Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module stops working after no effect is applied for a scene #792

Open
marvin-nerlich opened this issue Oct 13, 2024 · 0 comments
Open

Module stops working after no effect is applied for a scene #792

marvin-nerlich opened this issue Oct 13, 2024 · 0 comments
Labels
bug Something isn't working to be confirmed

Comments

@marvin-nerlich
Copy link

Expected Behavior

Module work properly and doesn't break a scene when no effect applied after a effect was applied.

Current Behavior

Module works, but if an effect was applied to a scene and was deactivated after, Foundry won't draw primary canvas and therefore stops working.
Error:

Error: Failed drawing primary canvas group: Cannot read properties of null (reading 'type'). Cannot read properties of null (reading 'type')
[Detected 1 package: fxmaster(4.1.0)]
at Hooks.onError (foundry.js:658:24)
at 🎁Hooks.onError#0 (libWrapper-wrapper.js:188:54)
at #draw (foundry.js:25057:15)
at async Canvas.draw (foundry.js:24941:5)
at async Scene.view (foundry.js:21362:7)

Steps to Reproduce

  1. Import fvtt-Scene-swamp_-the-magician-tower-1hW4NpTk9cHczB6a2.json as scene.
  2. Apply any weather effect
  3. Uncheck the applied weather effect
  4. Restart/reload Foundry
  5. Go to the imported scene and receive the error shown above

Context

First off: Yes, I know that the module is currently working for Foundry V12 but it seems to work for me and maybe the error helps with troubleshooting.

I checked the .json file of the scene and found the following code block:

    "fxmaster": {
      "effects": {
        "-=0": null
      },
      "invert": false
    },

After deleting the block or the contents of the block and reloading Foundry, everything works fine again.

Version

4.1.0

Foundry VTT Version

12.329

Operating System

Windows

Browser / App

Chrome

Game System

dnde5

Relevant Modules

No response

@marvin-nerlich marvin-nerlich added bug Something isn't working to be confirmed labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be confirmed
Projects
None yet
Development

No branches or pull requests

1 participant