Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capa-add-s3-permission-for-flatcar #74

Merged
merged 3 commits into from
Jun 13, 2023
Merged

capa-add-s3-permission-for-flatcar #74

merged 3 commits into from
Jun 13, 2023

Conversation

calvix
Copy link
Contributor

@calvix calvix commented Jun 13, 2023

toward shttps://github.com/giantswarm/roadmap/issues/996

@calvix calvix self-assigned this Jun 13, 2023
@calvix calvix requested a review from a team June 13, 2023 13:16
@T-Kukawka
Copy link
Contributor

@calvix can u add Changelog? as we are now versioning the permissions with changelog etc

T-Kukawka
T-Kukawka approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@T-Kukawka T-Kukawka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@calvix
Copy link
Contributor Author

calvix commented Jun 13, 2023

@calvix can u add Changelog? as we are now versioning the permissions with changelog etc

added, is that enough?

@T-Kukawka
Copy link
Contributor

@calvix can u add Changelog? as we are now versioning the permissions with changelog etc

added, is that enough?

all good <3

@calvix calvix merged commit 0b742a5 into master Jun 13, 2023
@calvix calvix deleted the capa-add-s3-permission-for-flatcar branch June 13, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Kukawka T-Kukawka T-Kukawka approved these changes

@whites11 whites11 whites11 approved these changes

Assignees

@calvix calvix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvix @T-Kukawka @whites11