Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample attributes display and updating #54

Open
only1chunts opened this issue Sep 12, 2016 · 5 comments
Open

sample attributes display and updating #54

only1chunts opened this issue Sep 12, 2016 · 5 comments

Comments

@only1chunts
Copy link
Member

only1chunts commented Sep 12, 2016

User story

As a curator
I want the sample admin pages to be more intuitive
So that I can update samples more easily

Acceptance criteria

Given I have a dataset with samples that have some attributes
When I goto the edit samples admin page
Then I see a neatly presented form with appropriate boxes for editing sample attribute names, values and units

Given I have a sample I want to add to a dataset
When I go to the edit sample admin page
Then I can input data in mandatory info in the Sample ID [text field], Species name [lookup field], Description [text field]

Given I have a sample I want to add to a dataset
When I go to the edit sample admin page
Then I can associate other attributes using the attribute name drop-down, value text field, and unit drop-down for each of them

image

Additional information

IMPORTANT: Copy the way it's done in the file admin form

the current admin pages combine all sample attributes and values and units into a single text clump, this needs to be separated out like in the submission wizard. i.e. a separate row for each attribute, and separate fields for each of attribute_name, value and units

@only1chunts
Copy link
Member Author

This could reuse the white label work on the sample input table, i,e, disaply the samples in tabular format with columns for each attribute

@ChrisArmit
Copy link

Sample attributes are to appear on separate rows so that they are more straightforward to edit. An example of how they should appear is below:

Description:RNA extracted from leaves of Meliosma cuneifolia
Analyte type:RNA
Tissue:leaf [BTO:0000713]
Alternative accession-SRA Study:ERP023948
Alternative accession-BioSample:SAMEA104170192
Specimen voucher:Chase 33142
Sample storage condition:frozen tissue
Sample source:M. Chase
Sample contact:L. Csiba

In contrast, for this example [dataset 100627] the sample attributes appear in the Admin pages as follows:

description="RNA extracted from leaves of Meliosma cuneifolia",analyte_type="RNA",tissue_type="leaf [BTO:0000713]",alt_acc_SRA_project="ERP023948",alt_acc_BioSample="SAMEA104170192",specimen_voucher="Chase 33142",="frozen tissue",sample_source="M. Chase",sample_contact="L. Csiba"

@only1chunts
Copy link
Member Author

could it be something like this:
image
where the left column is the attribute name, and as soon as you select a new one at the bottom box it appends a new row to be able to continue to add attributes as required.
The middle column is the box to enter the value
the right column should be auto filled from the preferred unit stored in the database, and allow to only select from suitable units list (that list needs to be defined for each attribute!) Where units are inappropriate (e.g. text fields like description then the units dropdown should not be shown.)
There would also need to be a delete button to remove rows.

@tuli
Copy link

tuli commented Jul 27, 2021

It looks good to me. I have no idea how much work that would be, but if it's a lot of work, then ChrisA's suggestion would be fine for me. It's not something we need to do that often.

@luistoptal
Copy link
Collaborator

I think before doing this it is better to wait for the following PRs to be merged as they contain work that is important for this one:

#2081
#2082
#2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Estimate
Development

No branches or pull requests

6 participants