Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AskFollow's function result is interpreted differently than documented #32

Open
gildor478 opened this issue Oct 24, 2020 · 0 comments
Open
Labels

Comments

@gildor478
Copy link
Owner

This bug has been migrated from artifact #1302 on forge.ocamlcore.org. It was assigned to user100.

user112 posted on 2013-08-01 19:09:32:

A function passed into FileUtil.find's ~follow parameter with the AskFollow constructor is logically flipped from what the documentation states. The documentation states that a file will be skipped if the function's return value is false. In the code however a true return value indicates that the given link should be skipped.

user148 replied on 2013-10-05 11:30:33:

In my current patch for bug #712, I change the behaviour of AskFollow so that "true" means "follow" (i.e. like the doc states).

I'd like to be sure which behaviour is the right one.

(I hadn't noticed that issue and only changed it because I rewrote the relevant function instead of copying it)

@gildor478 gildor478 added the bug label Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant