Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmp return None for identical files #59

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

jamesjer
Copy link
Contributor

Fixes #57. Given two distinct files with identical contents, the cmp function evalues to Some x, where x is the size of each file, instead of evaluating to None. This breaks the gettext tests, which expect None in that case. (And, on a human note, None just makes more sense to me, as it means there are no differences.)

@gildor478 gildor478 merged commit cb3aded into gildor478:master Dec 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocaml-gettext test fail with ocaml-fileutils 0.6.4
2 participants