Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Svelte Syntax Highlighting #6673

Closed
hyunbinseo opened this issue Jan 9, 2024 · 4 comments
Closed

Incorrect Svelte Syntax Highlighting #6673

hyunbinseo opened this issue Jan 9, 2024 · 4 comments
Labels

Comments

@hyunbinseo
Copy link

Describe the bug

Svelte's $: if( ) { } syntax seems to be broken. GitHub Gist

Currently, lang="ts" is required to correctly highlight this syntax.

image

Expected behaviour

In the above example, the highlight should be identical for JS and TS.

Related discussion

Additional notes

@lildude
Copy link
Member

lildude commented Jan 9, 2024

Closing as duplicate of pinned issue #6668

@lildude lildude closed this as completed Jan 9, 2024
@lildude
Copy link
Member

lildude commented Jan 9, 2024

Actually, cancel that. This will be an issue with the upstream grammar. Please open an issue there.

@hyunbinseo
Copy link
Author

Thanks for the comments. Am I supposed to create an issue on sveltejs/language-tools?

The syntax highlighting works on all other platforms - it is just broken on github.com.

This is the reason I've created this issue in this repository.

@lildude
Copy link
Member

lildude commented Jan 9, 2024

Yes. We take the grammar as provided by that repo so if it's not highlighting correctly, it something in the grammar... except if it's caused by the issue I originally highlighted.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants