Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DenizenScript Language Support #5773

Merged
merged 5 commits into from
Feb 17, 2022
Merged

Added DenizenScript Language Support #5773

merged 5 commits into from
Feb 17, 2022

Conversation

BreadcrumbIsTaken
Copy link
Contributor

@BreadcrumbIsTaken BreadcrumbIsTaken commented Feb 10, 2022

I added a TextMate grammar file for a language called DenizenScript!

Description

DenizenScript is a scripting language for Minecraft servers. As the language's syntax can easily become very hard to read without syntax highlighting (stuff within stuff that contain stuff that can also contain other stuff!), I decided it would be a good idea to contribute a grammar file that I wrote to Linguist!

note:
On the checkbox that says: The extension of the new language is used in hundreds of repositories on GitHub.com, I checked it off, even when there are not hundreds of repositories because of the announcement on issue #5756 and because DenizenScript is a language to program things like games and special items for Minecraft servers, most repos that use DenizenScript will most likely be private (due to Minecraft servers being monetizable). There could be more instances of DenizenScript in the wild, but there is something else that uses the same extension so I had to add some of the most common syntax in a few different search queries that DenizenScript has to filter it out. Just wanted to clear that up :).

Checklist:

The heuristics does not apply to me. Also, I got the color in the languages.yml from the logo.

@BreadcrumbIsTaken BreadcrumbIsTaken requested a review from a team as a code owner February 10, 2022 00:22
@BreadcrumbIsTaken BreadcrumbIsTaken changed the title Added DenizenScript Added DenizenScript Language Support Feb 10, 2022
Changed via a suggestion from @Nixinova
:)

Co-authored-by: Nixinova <[email protected]>
@BreadcrumbIsTaken
Copy link
Contributor Author

Hey @lildude, I was wondering if I can get an update on my PR? I hope you don’t mind the ping. I’m just excited about being able to contribute to something related to GitHub and would really like some feedback!
Thanks :)

@lildude
Copy link
Member

lildude commented Feb 17, 2022

Thanks @BreadcrumbIsTaken. I've tweaked your changes slightly as we don't need all the other extensions right now for this PR. They can be added later if peeps want them.

@lildude lildude merged commit dea6d47 into github-linguist:master Feb 17, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants