Add Magik language support

[ajhoward2]

Add a new programming language to Linguist, called Magik.

Description

Magik is a hybrid procedural and object-oriented language implemented as part of Smallworld Geographical Information System (GIS) and is provided by General Electric. Magik shares similarities with Smalltalk in terms of architecture and language features, providing readable syntax and an interactive development environment.

Checklist:

• I am adding a new language.
  • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • Search results for each extension:
      • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.magik
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • goworld.magik
      • xml_configurator.magik
      • robot_remote_cli.magik
      • vscode_dev.magik
    • Sample license(s): MIT, BSD-2, APACHE 2.0, APACHE 2.0
  • I have included a syntax highlighting grammar: https://github.com/OpenSmallworld/magik-vscode/
  • I have added a color
    • Hex value: #005E60
    • Rationale: This is an official colour of GE Vernova and Magik is largely used by Smallworld, which is a GE Vernova product.
  • I have updated the heuristics to distinguish my language from others using the same extension. No other language in this repository uses the extension .magik, so I did not add a heuristic

[Nixinova]

These text ones seem erroneous - only source.magik is used.

[ajhoward2]

Thank you for your feedback! I agree with this statement, however was unsure if I should modify grammars.yml as this was automatically generated by the scripts.

[lildude]

Do not manually modify this file. It's maintained by a script and should remain that way. The script will always find all grammars in the repo and add them to this file so there's nothing wrong with this.

[spenserblack]

Just from feedback I've gotten in my own PRs, I'm pretty sure that a 3000+ line sample is too large 🙂

[ajhoward2]

Thanks for the tip! I will remove it.

[sebastiaanspeck]

Is this PR still alive? I am working on a tree-sitter with a colleague of mine for Magik, which will improve the parsing of Magik even more. It would be great if Magik will be supported by linguist. It is already added to Rouge 5 years ago, which is used by GitLab.

[ge-timothy-chueh]

I believe it's still "Pending Popularity". @lildude apologies if this is documented somewhere, is there specific criteria we should try to meet to satisfy the popularity requirement?

[lildude]

I believe it's still "Pending Popularity". @lildude apologies if this is documented somewhere, is there specific criteria we should try to meet to satisfy the popularity requirement?

Yes. See the CONTRIBUTING.md file and the issue it references.

[sebastiaanspeck]

I believe it's still "Pending Popularity". @lildude apologies if this is documented somewhere, is there specific criteria we should try to meet to satisfy the popularity requirement?

Yes. See the CONTRIBUTING.md file and the issue it references.

Thank you, could you re-assess this PR since it has almost 1000 code search results.

[lildude]

Thank you, could you re-assess this PR since it has almost 1000 code search results.

It'll be re-assessed when I'm close to making a new release, but even without looking, this doesn't meet the doc'd requirements detailed in the issue referenced in the CONTRIBUTING.md file.

[sebastiaanspeck]

Thank you, could you re-assess this PR since it has almost 1000 code search results.

It'll be re-assessed when I'm close to making a new release, but even without looking, this doesn't meet the doc'd requirements detailed in the issue referenced in the CONTRIBUTING.md file.

I would like to help to update this PR to meet the doc'd requirements. Are we talking about the same issue? #5756.
Magik is a somewhat closed environment and not much open-source code will be found online since most customers/users are network operators that use GIS/Smallworld and those companies are regulated via the public authorities.

I hope we can reach consensus and maybe make an exception for this language?

[lildude]

I'm referring to #5756

We've always relied upon public repo usage (we can't measure private repo usage) and allowing exceptions "just this once" opens us up to a similar time-consuming fight each and every time someone develops "the next greatest thing, promise on my hamster's life" or adds support for a lesser used langauge. Sticking with a consistent policy ensures fair treatment of all and everyone knows what the expectations are.

[sebastiaanspeck]

I'm referring to #5756

We've always relied upon public repo usage (we can't measure private repo usage) and allowing exceptions "just this once" opens us up to a similar time-consuming fight each and every time someone develops "the next greatest thing, promise on my hamster's life" or adds support for a lesser used langauge. Sticking with a consistent policy ensures fair treatment of all and everyone knows what the expectations are.

What is the "normal" search query for number of files per extension? If we include forks, we already have 1K files.

[sebastiaanspeck]

Magik has been added to sourcegraph lately and opened sourcegraph/zoekt#790 to include any languages that linguist won't/don't support right now.. It would be for the best if linguist adds Magik-support