Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should csrf be a required attribute? #53

Open
koddsson opened this issue May 7, 2021 · 1 comment
Open

Should csrf be a required attribute? #53

koddsson opened this issue May 7, 2021 · 1 comment

Comments

@koddsson
Copy link
Contributor

koddsson commented May 7, 2021

Right now, we exit early if there is no CSRF token. Maybe we should allow users to supply a CSRF token and not mandate it optionally?

// If some attributes are missing we want to exit early and make sure that the element is valid.
if (!src || !csrf || !state) {
return
}

@rebelagentm
Copy link

FWIW, there may be some applications outside of dotcom that wouldn't need to set this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants