Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HTMLDialogElement constructor versions for Opera/Safari #63

Merged

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Oct 6, 2024

Hi, just came across this table via your engineering blog, looks like these versions just got switched around?

Before

Screenshot 2024-10-06 at 10 30 15 am

After

Screenshot 2024-10-06 at 10 58 18 am

HTMLDialogElement Constructor

@erkde erkde requested a review from a team as a code owner October 6, 2024 00:16
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thanks again for the contributions.

@dgreif dgreif merged commit a84376c into github:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants