Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip repo if no package manager found #270

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ricardojdsilva87
Copy link
Contributor

@ricardojdsilva87 ricardojdsilva87 commented Nov 18, 2024

Pull Request

Proposed Changes

  • Fixes a bug introduced on this PR where if a repository did not had any package manager detected, the script continued and tried to modify an object that did not existed. The continue notation breaks the cycle to go to the next package manager.
  • Makes this link more permanent referenced on this comment
  • The following logic worked only if a REPOSITORY was set , not working with the ORGANIZATION configuration. Now a file always needs to exist locally, either on the repository where the action would run or locally on the computer, triggering an error if it does not exist and the DEPENDABOT_CONFIG_FILE is set
  • Added detection for gradle and devcontainers package managers
  • Needed tests were added
---------- coverage: platform darwin, python 3.13.0-final-0 ----------
Name                 Stmts   Miss  Cover   Missing
--------------------------------------------------
auth.py                 28      0   100%
dependabot_file.py      90      0   100%
env.py                 134      4    97%   46-47, 167-168
evergreen.py           141      3    98%   311-312, 365
--------------------------------------------------
TOTAL                  393      7    98%

Required test coverage of 80% reached. Total coverage: 98.22%

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@github-actions github-actions bot added the fix label Nov 18, 2024
@ricardojdsilva87 ricardojdsilva87 changed the title Fix/skip repo if no package manager found fix: skip repo if no package manager found Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant