You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use Gitlens to perform code reviews quite a bit. It's pretty good, but there are some rough areas which I hope to get advice about or suggest some improvements.
Currently my workflow is like this:
use gh pr checkout {branch} to checkout the local branch
open vscode to this branch and open gitlens
in another terminal, do a git log of the branch to keep a list of commits
in gitlens commit view, go to the first commit of the branch, use switch to commit and begin reviewing
go back to terminal to get next commit, usually switch to this commit in the terminal.
This flow could become a lot better with some tweaks to Gitlens. Here are some issues
Switching to a commit is very useful because it allows the "Open previous changes with working file" option on each file in the commit view, and allows LSP tools to function
However, when you do this there is no way to keep in-view the HEAD of the branch, instead Gitlens commit view completely updates and chops off the later commits
Suggestion:
Would it be possible to add an option such as "pin commit view" which holds the commit view steady as you switch between commits in a branch? Then the following work flow could be used:
use gh pr checkout {branch} to checkout the local branch
open vscode to this branch and open gitlens, pin commit view.
in gitlens commit view, go to the first commit of the branch, use switch to commit and begin reviewing
go back to gitlens and use switch commit on next commit, repeat.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello,
I use Gitlens to perform code reviews quite a bit. It's pretty good, but there are some rough areas which I hope to get advice about or suggest some improvements.
Currently my workflow is like this:
gh pr checkout {branch}
to checkout the local branchgit log
of the branch to keep a list of commitsgitlens
commit view, go to the first commit of the branch, useswitch to commit
and begin reviewingThis flow could become a lot better with some tweaks to Gitlens. Here are some issues
HEAD
of the branch, insteadGitlens
commit view completely updates and chops off the later commitsSuggestion:
Would it be possible to add an option such as "pin commit view" which holds the commit view steady as you switch between commits in a branch? Then the following work flow could be used:
gh pr checkout {branch}
to checkout the local branchgitlens
commit view, go to the first commit of the branch, useswitch to commit
and begin reviewinggitlens
and useswitch commit
on next commit, repeat.Beta Was this translation helpful? Give feedback.
All reactions