Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-based auto-inheritance code? #4

Open
cogat opened this issue Dec 6, 2010 · 0 comments
Open

Remove python-based auto-inheritance code? #4

cogat opened this issue Dec 6, 2010 · 0 comments

Comments

@cogat
Copy link
Collaborator

cogat commented Dec 6, 2010

The code that creates new Events and injects default values from the parent is pretty fragile. It also doesn't do any form validation and can potentially create invalid data (e.g. empty or duplicate slugs)

The IxC branch (409de8f) has implemented an admin method that works for django admin by populating a GET string for the new Event form. This even works with m2m fields. AFAICS this covers the main use case.

I'm fairly sure we can just strip out the inheritance code (and the callable default voodoo), but the tests need updating to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant