Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing commits on top of ones with "weird" manifests fail #182

Open
glandium opened this issue Jul 13, 2018 · 1 comment
Open

Pushing commits on top of ones with "weird" manifests fail #182

glandium opened this issue Jul 13, 2018 · 1 comment

Comments

@glandium
Copy link
Owner

STR:

  • Take a clone of the octave or pypy repositories.
  • Checkout a revision that has a manifest with a leading / or an embedded //.
  • Create a commit on top of this
  • Push or bundle.

This fails with:

  File "bundle.py", line 251, in create_hg_manifest
    sha1_after, str(manifest_line.node),
AttributeError: 'tuple' object has no attribute 'node'

and

  File "bundle.py", line 162, in create_hg_manifest
    path, f, (change, (manifest_line_p1, manifest_line_p2)) = line
ValueError: need more than 0 values to unpack

for merges

@glandium glandium added this to the 0.5.x milestone Aug 11, 2018
@glandium glandium removed this from the 0.5.x milestone Feb 14, 2020
@glandium
Copy link
Owner Author

glandium commented May 4, 2024

Recent STR:

  • git clone hg::https://hg.savannah.gnu.org/hgweb/octave/
  • cd octave
  • git checkout 022cd38197d66a4079fc96f9ba15a3d5af68bda0
  • echo >> gui/Changelog
  • git commit -a -m foo
  • git cinnabar bundle foo.hg HEAD^!

Error message is now:

fatal: Something went wrong Right(Modified { from: RecursedTreeEntry { oid: Blob(BlobId("291a3ff9337e51f702594128b9cda29d7e85ea3c")), mode: 100644 }, to: RecursedTreeEntry { oid: Blob(BlobId("4e69ccae0b7c24fb09553e2ed4d0f45b6d20ed82")), mode: 100644 } })

from

thing => die!("Something went wrong {:?}", thing),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant