fatal: Malformed file chunk for a0054c999f5d0c4ef952e18f871e33b085f42ec1

[saschanaz]

> git -c cinnabar.check=traceback pull
WARNING Mercurial libraries not found. Falling back to experimental native access.
Reading 130 changesets
Reading and importing 130 manifests
Reading and importing 30 revisions of 23 filesfatal: Malformed file chunk for a0054c999f5d0c4ef952e18f871e33b085f42ec1
fast-import: dumping crash report to .git/fast_import_crash_572
Unpacking objects: 100% (21/21), 32.89 KiB | 2.19 MiB/s, done.
Reading and importing 235 revisions of 190 files
Traceback (most recent call last):
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\util.py", line 1002, in run
    retcode = func(args)
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\git-remote-hg", line 53, in main
    helper.run()
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\remote_helper.py", line 87, in run
    self.import_(*args)
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\remote_helper.py", line 422, in import_
    getbundle(self._repo, self._store, heads,
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\hg\repo.py", line 1044, in getbundle
    apply_bundle(store)
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\hg\repo.py", line 866, in __call__
    for rev_chunk in progress_enum(
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\util.py", line 223, in progress_enum
    for count, item in enum_iter:
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\hg\repo.py", line 842, in enumerate_files
    for count_chunks, (name, chunk) in enumerate(iterator, start=1):
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\hg\repo.py", line 810, in iter_files
    fh.write(chunk)
OSError: [Errno 22] Invalid argument
fatal: Unsupported command: error
fast-import: dumping crash report to .git/fast_import_crash_18384
fatal: error while running fast-import
Exception ignored in atexit callback: <bound method GitHgHelper.close of <class 'cinnabar.helper.GitHgHelper'>>
Traceback (most recent call last):
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\helper.py", line 513, in close
    super(GitHgHelper, self).close()
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\helper.py", line 108, in close
    self._helper.wait()
  File "C:\Users\sasch\Documents\GitHub\git-cinnabar\cinnabar\util.py", line 834, in wait
    fh.close()
OSError: [Errno 22] Invalid argument

This somehow started today.

[saschanaz]

Crash report:

fast-import crash report:
    fast-import process: 9876
    parent process     : 1
    at 2022-01-11 15:19:01 +0000

fatal: Unsupported command: error

Most Recent Commands Before Crash
---------------------------------
* error

Active Branch LRU
-----------------
    active_branches = 0 cur, 5 max

  pos  clock name
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Inactive Branches
-----------------

Marks
-----

-------------------
END OF CRASH REPORT

[glandium]

git cinnabar --version?

[saschanaz]

Sorry, forgot it 😅

> git cinnabar --version
0.5.9a
module-hash: 5e3702f55a47d0bbe5d819cb93d960888138b9be
helper-hash: 35b90b2bf83cfb025e256ca1d65dc8763437b517

[glandium]

I suppose if you do git show refs/cinnabar/metadata^5:ae/dd/79826df584eafb9e63cce0bb9894c03e5485, it fails?

[saschanaz]

Hmm, not sure this is what you expect, but anyway:

> git show refs/cinnabar/metadata^5:ae/dd/79826df584eafb9e63cce0bb9894c03e5485
fatal: invalid object name 'refs/cinnabar/metadata^5'.
> git show "refs/cinnabar/metadata^5:ae/dd/79826df584eafb9e63cce0bb9894c03e5485"
fatal: invalid object name 'refs/cinnabar/metadata^5'.

[glandium]

This doesn't make sense. Did you run that in the same repo as the original pull?

[saschanaz]

Sigh, I'm dumb. I was in git-cinnabar directory, so here it is again:

> git show refs/cinnabar/metadata^5:ae/dd/79826df584eafb9e63cce0bb9894c03e5485
fatal: path 'ae/dd/79826df584eafb9e63cce0bb9894c03e5485' does not exist in 'refs/cinnabar/metadata^5'

[glandium]

Ok, so this looks like is the same as #207, but it should have been caught earlier. Do you know what version of git-cinnabar you were running in early december?
Can you send a bundle created with something like:
git bundle create $file refs/cinnabar/metadata --not --remotes origin? (you may want to add any other remote you have with a --remotes too)

[saschanaz]

Do you know what version of git-cinnabar you were running in early december?

I don't, but git reflog says:

d573fca (HEAD -> master, origin/try, origin/master, origin/HEAD) HEAD@{0}: pull: Fast-forward
04b8365 HEAD@{1}: pull: Fast-forward
1ffb93f HEAD@{2}: clone: from https://github.com/glandium/git-cinnabar

So there's not many candidates and it's probably 04b8365.

[saschanaz]

Just shared the file to you.

> git bundle create ../output.gitbundle refs/cinnabar/metadata --not --remotes origin
warning: unable to access '_mobile/_android/_tests/_browser/_chrome/_tp5/_amazon.com/_www.amazon.com/_Kindle-Wireless-Reader-Wifi-Graphite/_dp/_B002Y27P3M/_%5C%22http%3A/_g-ecx.images-amazon.com/_images/_G/_01/_x-locale/_personalization/.gitattributes': Filename too long
Enumerating objects: 9523929, done.
Counting objects: 100% (9523889/9523889), done.
Compressing objects: 100% (4633465/4633465), done.
Total 9523482 (delta 4761222), reused 9519591 (delta 4758211), pack-reused 0

Hopefully that warning shouldn't be too important here....

[glandium]

What remote(s) do you have on the repo? it seems to have stuff that is not in mozilla-unified.

Edit: Oh, it's a gecko-dev graft clone.

[glandium]

Interestingly, your repo shows this type of corruption has happened multiple times, some of which should have been caught earlier than now.
Run git update-ref refs/cinnabar/metadata d17ccfe5efcfe17051429c3bba1e27ebee8d9bcd and update your remote again. This will fortunately not affect the commit sha1s. If you have a fast internet connection, you may just want to use git cinnabar reclone.

Since this is the same as #207, I could close this issue, but I'll keep it around until I figure out why this wasn't detected at the moment the corruption happened.

[glandium]

Some really weird things happened in this repo, and I have absolutely no idea how. I also have absolutely no idea why, if you were indeed using 04b8365, you didn't get errors from the code added in 3ecabe6, because if I do hack git-cinnabar to make it pretend it generated the broken metadata, the test correctly finds the breakage when updating from the last correct state to the corrupted state.

[saschanaz]

One possibility in my mind in that the version mismatch of helper executable right after updating cinnabar, since I frequently forget doing git cinnabar download and then see the warning. But no idea that actually affected anything.

[glandium]

Since this is the same as #207, I could close this issue, but I'll keep it around until I figure out why this wasn't detected at the moment the corruption happened.

We figured that out in #295 and it's now fixed in master.